-
Notifications
You must be signed in to change notification settings - Fork 253
CPU Arch now lives under host.cpu #2374 #2376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CPU Arch now lives under host.cpu #2374 #2376
Conversation
a6537ce
to
52ca36e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favour of this. We should note that this will probably break some existing resource detectors, namely the one in the Collector (but it will likely need a few changes to come along with other semconv changes we made so I think it's okay).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of moving the arch within the cpu
namespace, but what is the difference between the host.cpu.*
attributes and cpu.*
ones? https://github.com/open-telemetry/semantic-conventions/blob/main/model/cpu/registry.yaml#L4 Should the host.cpu.*
attributes only be part of system.*
metrics?
Should we align these two groups?
At the moment, the I'll tag in @jsuereth and @dmitryax to answer this question from the entities perspective. |
I was actually think about doing that but decided against it as hopefully entity relationships will help that scenario. What about if a message was added on the cpu.* namespace stating something similar to geo in relation to nesting it. I would like to eventually see the scenario where both a device & the host could have cpu objects especially in virtualised environments which is where the cpu entity would come in hence difficult to put it at the root. |
065147b
to
41a3f3e
Compare
So I have been thinking about this some more especially when trying to improve the brief on the page. While also thinking about how a consistent experience can be offered to users of otel and avoid duplication. What your thought about moving This would mean that the hardware namespace is where all fixed hardware properties are described. If you are on board @braydonk / @rogercoll I can make those changes tomorrow. |
62d43ea
to
695b73c
Compare
I think that even this attribute is still not used in
Although the cpu hw.type is already defined, I find the hw. namespace for cpu attributes redundant. hw. implies a meaningful distinction between hardware and software representations of architecture, but in practice, |
Agree we have a couple of scenarios for using the value of host.arch And it could be used more. I think it would be beneficial to have 2 distinct attributes:
Ideally eventually we could use a shared enum between them. |
23fc439
to
55d5aa3
Compare
@braydonk - Can you get the @open-telemetry/semconv-system-approvers group to make a decision on this here? |
Don't forget we also have the |
Signed-off-by: James Thompson <[email protected]>
Signed-off-by: James Thompson <[email protected]>
55d5aa3
to
60954b0
Compare
Fixes #2374
Changes
This moves the CPU arch to now be under the host.cpu namespace rather than directly under the host namespace
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]